stefanofontanelli / ColanderAlchemy

ColanderAlchemy helps you autogenerating Colander schemas based on SQLAlchemy mapped objects.
Other
63 stars 33 forks source link

Exclude tests from package install #84

Closed ronnix closed 9 years ago

ronnix commented 9 years ago

We don't want the tests directory to end up in site-packages on package install.

tisdall commented 9 years ago

Makes sense. Did this cause any sort of issue, though?

ronnix commented 9 years ago

No issues for me, but I guess it could conflict if two packages both want to install tests/test_foo.py...

tisdall commented 9 years ago

I was just wondering what prompted the PR. Most PR's come about because of some issue the developer ran across.

ronnix commented 9 years ago

Well, when using Sublime Text I like to have my virtualenv's site-packages folder open in the project in addition to my own source code. It makes it easier to jump quickly to a library's source code when needed, or to to code completion. While browsing the contents of this site-packages directory in the sidebar, I stumbled upon a tests directory that shouldn't be there. I then tracked which package had put it there, and did a quick friendly PR. :)