Closed stokito closed 9 years ago
\t
The line:
if (config?.upload?.baseurl.startsWith("http")) {
may cause NPE. Mayebe it wiuld be better to add safe navigation before startsWith() i.e.:
startsWith()
if (config?.upload?.baseurl?.startsWith("http")) {
if (log.isDebugEnabled()) { log.debug "==============================================" log.debug "FILEMANAGER" log.debug "baseDir = ${baseDir}" log.debug "baseUrl = ${baseUrl}" log.debug "type = ${type}" log.debug "space = ${space}" log.debug "showThumbs = ${showThumbs}" log.debug "==============================================" }
The check log.isDebugEnabled() is not needed because loger itself check it
log.isDebugEnabled()
\t
in source code instead of spacesThe line:
may cause NPE. Mayebe it wiuld be better to add safe navigation before
startsWith()
i.e.:The check
log.isDebugEnabled()
is not needed because loger itself check it