stefanogualdi / grails-ckeditor

Grails CKEditor plugin
http://grails.org/plugin/ckeditor
Apache License 2.0
23 stars 32 forks source link

Small code issues #14

Closed stokito closed 9 years ago

stokito commented 9 years ago
  1. A lot of tabs \t in source code instead of spaces
  2. OpenFileManagerConnectorController:129

The line:

            if (config?.upload?.baseurl.startsWith("http")) {

may cause NPE. Mayebe it wiuld be better to add safe navigation before startsWith() i.e.:

            if (config?.upload?.baseurl?.startsWith("http")) {
  1. In the OpenFileManagerConnectorController:201
        if (log.isDebugEnabled()) {
            log.debug "=============================================="
            log.debug "FILEMANAGER"
            log.debug "baseDir = ${baseDir}"
            log.debug "baseUrl = ${baseUrl}"
            log.debug "type = ${type}"
            log.debug "space = ${space}"
            log.debug "showThumbs = ${showThumbs}"
            log.debug "=============================================="
        }

The check log.isDebugEnabled() is not needed because loger itself check it

stokito commented 9 years ago

17 pull request