Migrated to Grails 3 - Githubissues

stefanogualdi / grails-ckeditor

Grails CKEditor plugin

http://grails.org/plugin/ckeditor

Apache License 2.0

23 stars 32 forks source link

Migrated to Grails 3 #23

Closed puneetbehl closed 8 years ago

puneetbehl commented 8 years ago

@stefanogualdi It seems like you merged some new changes into master. I can work on rebasing on top of current master. But, I have few questions:

plugin name and version in static resource urls was not working so I have removed plugin from all g.resource(dir: '<some-dir>', plugin: 'ckeditor') tags.
In Grails 3, all static resources are served as /static/<path-to-resource> so for this I have added default config in plugin.groovy

grails.resources.pattern = '/**'
grails.resources.uri.prefix = ''

Please let me know if you see any concerns or issues.

stefanogualdi commented 8 years ago

I Puneet, first of all tank you for your contribution.

I've just merged a PR from another user. The only modification was on PluginUtils.groovy.

Feel free to change whatever you want

puneetbehl commented 8 years ago

Done, resolved conflicts :-)

stefanogualdi commented 8 years ago

thank you :)

Sent from mobile

On 25 Mar 2016 21:28, "Puneet Behl" notifications@github.com wrote:

Done, resolved conflicts :-)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/stefanogualdi/grails-ckeditor/pull/23#issuecomment-201481165

stefanogualdi commented 8 years ago

Merged on master, thank you!

puneetbehl commented 8 years ago

@stefanogualdi Do you want me to release over binary as well?

stefanogualdi commented 8 years ago

I’m just doing this! :)

On 28 March 2016 at 10:27:23, Puneet Behl (notifications@github.com) wrote:

@stefanogualdi Do you want me to release over binary as well?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

puneetbehl commented 8 years ago

Cool :-) One more thing I noticed that one commit 98f1bf0: cleanup is missing in merge.

stefanogualdi commented 8 years ago

yes, I didn't notice the commit because I was manually merging. anyway I deleted the files in my branch.

sent from mobile On 28 Mar 2016 10:36, "Puneet Behl" notifications@github.com wrote:

Cool :-) One more thing I noticed that one commit 98f1bf0: cleanup https://github.com/stefanogualdi/grails-ckeditor/pull/23/commits/98f1bf056379dca7345f9f8af870aaff849823bd is missing in merge.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/stefanogualdi/grails-ckeditor/pull/23#issuecomment-202300922