stefanogualdi / grails-ckeditor

Grails CKEditor plugin
http://grails.org/plugin/ckeditor
Apache License 2.0
23 stars 32 forks source link

A bug that seems to ignore the baseDir configuration #35

Open salehmamdouh1984 opened 8 years ago

salehmamdouh1984 commented 8 years ago

Probably a bug that causes baseDir configuration to be ignored is baseurl configuration is not defined.

Source File : https://github.com/stefanogualdi/grails-ckeditor/blob/3.6.x/grails-app/controllers/org/gualdi/grails/plugins/ckeditor/OpenFileManagerConnectorController.groovy

OpenFineManagerConnectorController#Line 206

if (config?.upload?.baseurl) { baseDir = PathUtils.checkSlashes(config?.upload?.basedir, "L+ R-") + PathUtils.checkSlashes(baseUrl, "L+ R+") } else { baseDir = servletContext.getRealPath(baseUrl) baseDir = PathUtils.checkSlashes(baseDir, "R+") } onfig?.upload?.baseurl should be onfig?.upload?.basedir

stefanogualdi commented 8 years ago

Why do you think it is a bug? Maybe my documentation is not clear about this setting , and this is the real bug :)

You have to define ckeditor.upload.baseurl only if you want to serve the uploaded files outside of the web space of the application. In this case ckeditor.upload.basedir is considered as the absolute path to the storage area on the file system.

Please take a look here: http://stefanogualdi.github.io/grails-ckeditor/docs/index.html#configuration