search

stefanogualdi / grails-ckeditor

Grails CKEditor plugin
http://grails.org/plugin/ckeditor
Apache License 2.0
23 stars 32 forks source link

Grails 4 upgrade #43

Open cbmarcum opened 3 years ago

cbmarcum commented 3 years ago

Update to Grails 4.0.5 and Gradle 6.7. Also added generating groovydoc and source jars and signing. (need to add a properties file with credentials not included)

ZacharyKlein commented 3 years ago

@cbmarcum @stefanogualdi Any ETA on getting this PR merged and released?

cbmarcum commented 3 years ago

@cbmarcum @stefanogualdi Any ETA on getting this PR merged and released? @zacharyklein My fork master branch is updated and available on Bintray if you need it. https://bintray.com/cmarcum/maven/net.codebuilders%3Agrails-ckeditor/4.5.9.1

muehlboeck commented 2 years ago

I tried to use your forked version. The bintray link above is not working anymore so I build the jar and included it into my grails 4.0.13 project. Whenever I add the tag it now fails with:

HibernateException occurred when processing request: [GET] /js/ckeditor/ckeditor.js No Session found for current thread. Stacktrace follows:

org.hibernate.HibernateException: No Session found for current thread

any ideas how this could be fixed?

cbmarcum commented 2 years ago

I tried to use your forked version. The bintray link above is not working anymore so I build the jar and included it into my grails 4.0.13 project. Whenever I add the ckeditor:resources/ tag it now fails with:

HibernateException occurred when processing request: [GET] /js/ckeditor/ckeditor.js No Session found for current thread. Stacktrace follows:

org.hibernate.HibernateException: No Session found for current thread

any ideas how this could be fixed?

I'm not sure why you might be getting a hibernate error. Are you using Spring Security and if so allowed access to that path?

muehlboeck commented 2 years ago

yes, I am using spring security and I have added: [pattern: '/js/**', access: ['permitAll']], and [pattern: '/js/**', filters: 'none'],

I figured this would solve the issue but I have no luck so far.

cbmarcum commented 2 years ago

I use [pattern: '/**/js/**', access: ['permitAll']] and [pattern: '/**/js/**', filters: 'none']

cbmarcum commented 2 years ago

you might also make sure you're saving within a transaction. For instance is your save and update methods annotated with @Transactional

muehlboeck commented 2 years ago

sadly, I never got that far. All I did was including the jar and adding the resources tag to my gsp. Is there a change that this will make it back into the official plugin repository at some point?

cbmarcum commented 2 years ago

I've put mine in JFrog artifactory: try maven { url "https://codebuilders.jfrog.io/artifactory/default-maven-local/" } and compile "net.codebuilders:ckeditor:4.5.9.1" It may show up in grails core but I can't be sure.

muehlboeck commented 2 years ago

great. Thanks. I will give this a try.

On Thu, Feb 3, 2022 at 5:15 PM Carl Marcum @.***> wrote:

I've put mine in JFrog artifactory: try maven { url " https://codebuilders.jfrog.io/artifactory/default-maven-local/" } and compile "net.codebuilders:ckeditor:4.5.9.1" It may show up in grails core but I can't be sure.

— Reply to this email directly, view it on GitHub https://github.com/stefanogualdi/grails-ckeditor/pull/43#issuecomment-1029451778, or unsubscribe https://github.com/notifications/unsubscribe-auth/APFVNCARRESM46RIHNDIVF3UZL47DANCNFSM4TWLTCIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

muehlboeck commented 1 year ago

just a quick update on this. It works great even with grails 5.2.x - but as soon as I use spring-security things break. Thanks for making this available for users without the spring-security requirement.

On Fri, Feb 18, 2022 at 8:52 AM J-S Muehlboeck @.***> wrote:

great. Thanks. I will give this a try.

On Thu, Feb 3, 2022 at 5:15 PM Carl Marcum @.***> wrote:

I've put mine in JFrog artifactory: try maven { url " https://codebuilders.jfrog.io/artifactory/default-maven-local/" } and compile "net.codebuilders:ckeditor:4.5.9.1" It may show up in grails core but I can't be sure.

— Reply to this email directly, view it on GitHub https://github.com/stefanogualdi/grails-ckeditor/pull/43#issuecomment-1029451778, or unsubscribe https://github.com/notifications/unsubscribe-auth/APFVNCARRESM46RIHNDIVF3UZL47DANCNFSM4TWLTCIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>