stefanopagliari / bibnotes

359 stars 30 forks source link

[Bug] Keys for additional highlight formatting do not work #128

Open PhilippTh opened 2 years ago

PhilippTh commented 2 years ago

Thanks for the great work so far!

I'm using bibnotes 0.9.209 and better bibtex 6.7.19.

Unfortunately, neither "+" nor "%" nor "todo" have any effects on the extracted annotation. Additionally, when using "+", the last key in the previous annotation gets deleted.

debugout.txt

stefanopagliari commented 2 years ago

Hi @PhilippTh,

I would like to replicate the issue. Would you be able to share with me the exported json of that note? In order to upload it here you would need to rename the extension from .json to .txt

PhilippTh commented 2 years ago

Sure, here you go.

My Library.txt

PhilippTh commented 1 year ago

Hey @stefanopagliari

Curious if you were able to look into this issue?

stefanopagliari commented 1 year ago

@PhilippTh sorry, I had to interrupt the development of the plugin. I see that there a few references in the json file you sent me. Could you please point me to one where you are encountering the problem regarding "+", "%", or "todo"?

I'm looking at the file you shared with me and you can't find any highlight with the added comment "todo". I see you wrote "todo test" once, but this will not be recognised as equivalent to "todo"

PhilippTh commented 1 year ago

@stefanopagliari Thanks for the reply. In line 28168 of the library.txt file you can find the '+' symbol that I'm referring to.

Regarding 'todo': Is this keyword case-sensitive or what is the difference to the syntax showcased here?

Thanks a lot and best regards Philipp

stefanopagliari commented 1 year ago

@PhilippTh you would like the highlight "1% -2% is not significant enough to consider this an influence to the decision." to be united with the next highlight "a sequence like 0101001011001010100110100 is more likely than a sequence like 0101011111011000001001101. A judge granting asylum may worry about being too lenient if s/he grants too many decisions in a row or being too harsh if s/he denies too many in a row. Such a judge might actively, negatively autocorrelate. Indeed, if the previous decision was to grant asylum, the next decision is 1–2% points less likely to grant asylum."?

stefanopagliari commented 1 year ago

@PhilippTh Can you please confirm that the "+" is added as a comment to an highlight rather than a separate pop-up box?

stefanopagliari commented 1 year ago

@PhilippTh I wanted to check something. Could you please open Zotero -> Preferences -> Advanced -> Config Editor and check what value you have in extensions.zotero.annotations.noteTemplates.highlight

If the value is different from the default, try replacing it with: {{highlight quotes='true'}} {{citation}} {{comment}} {{if tags}} Tag: {{tags join='; '}}{{endif}}