stefanor / signalk-victron-ble

Simple Signal K Node server plugin to read data from Victron devices using Instant Data over BLE
Apache License 2.0
10 stars 3 forks source link

SmartLithium support #12

Closed orymate closed 1 month ago

orymate commented 8 months ago

keshavdv/victron-ble#47 adds support for SmartLithium batteries, which would be nice to support with SignalK.

Unfortunately I can't use this plugin because I couldn't make the python lib working on my cerbo/VenusOS. So I run a different wrapper around the python library, and feed SignalK through deltas over TCP. The mapping I do may be useful however: https://github.com/orymate/smart-lithium-ble-sk/blob/main/smart_lithium_ble_sk/scanner.py#L35-L50

gregsyoung commented 6 months ago

i note that keshadev has added support for smart batteries, also saw a msg from @j9brown that he was adding and merging? .. but trying to understand the current status of support in signalk-victron-BLE plugin?

ive tested but it doesnt appear to find my smart batteries

stefanor commented 6 months ago

I note that keshadev has added support for smart batteries,

Where? https://github.com/keshavdv/victron-ble/pull/47 hasn't landed yet

gregsyoung commented 6 months ago

did i misread this?

https://github.com/keshavdv/victron-ble/pull/49

stefanor commented 6 months ago

That hasn't landed yet, either.

gregsyoung commented 6 months ago

ah… ok .. im not overly familiar with github, push, pull , metge etc requests/status

… my bad.

but definitely looking forward to test with my smart batteries :0

gregsyoung commented 6 months ago

and yes, i have two distributors in my system that will test its functionality also