search

stefanor / signalk-victron-ble

Simple Signal K Node server plugin to read data from Victron devices using Instant Data over BLE
Apache License 2.0
6 stars 2 forks source link

MPPT values have the wrong units #9

Open elafargue opened 9 months ago

elafargue commented 9 months ago

Using a Victron MPPT, I noticed that all the values that are logged to SignalK are in volts, including current, yield, panel power, charging mode, etc...

stefanor commented 9 months ago

Values are logged numerically. The units are specified by the signalk spec

elafargue commented 9 months ago

Oh right, so it looks like the SignalK spec doesn't know the right units for those measurement types, then? Happy to open a PR there if you point me in the right direction...

paalkr commented 2 months ago

I noticed that all mppt values are now registered with the correct unit, except for the yieldToday. This shows up in SignalK as J (joule) instead of Wh. The actual value is identical to what the Victron app displays, but in the Victron app the unit is in fact Wh. Is it possible for me to tell SignalK that the value is Wh? If SignalK expects the value to be Wh, then the plugin should convert the value it reads from the BLE device from Wh to joule befo posting the data to SignalK.

paalkr commented 1 month ago

I notice this is fixed in the code, but the fix is not included with the most recent release. Would it be possible to cut a new release with all the most recent changes to the code?