Open jsdevtom opened 6 years ago
stefanoslig
commented
6 years ago Hello Tom! Yes, it's something I really wanted to do but I didn't have enough time for this right now. To be honest my idea was to create a PWA version of the app. What do you think? Could you tell which is your suggestion? I want to upgrade the repo in Angular 6 too! Thank you!
cristianmartinez
commented
6 years ago Hey @stefanoslig, this is a really good project. Are you still interested in creating the PWA features for this project? let me know if you need help with it. I also want to suggest to use ngrx store facades. https://medium.com/@thomasburleson_11450/ngrx-facades-better-state-management-82a04b9a1e39 Let me know what do you think.
stefanoslig
commented
6 years ago Hello @cristianmartinez. Thank you! Yes It's in my plans to use facades. I uploaded a branch where I refactored the article lib in order to use facades. I have done some other changes too in order to avoid some dependencies between some libs. You can see the corresponding pull request here pr. I will do the same for the other libs in separated branches for each lib.
As for the PWA, the major problem right now is that I don't have mobile-friendly css. And also, I don't believe that the PWA should be a different app. Instead, the main app must be a PWA.
Thank you for your time creating this repo!
I suggest creating a second app for this repo so that the real world example is more true to real life. Please consider that one of the main motivations for using a mono repo is to reuse libraries in other apps, and seeing this in practice, I believe, would help users understand how to use nx in a multi application.
What are your opinions regarding my suggestion? Thanks in advance