stefanpejcic / OpenPanel

A highly customizable web hosting control panel built with Docker 🐳
https://openpanel.com
216 stars 33 forks source link

Incorectly representing plans OS image #227

Closed caesarmind closed 1 month ago

caesarmind commented 1 month ago

OpenPanel version(s) affected

0.3.2.

What OS are you using?

Ubuntu

Description

Screenshot 2024-10-21 at 18 07 02

I am using apahe/mariadb image for basic/deluxe packages and in the package list it says: "custom os".

How to reproduce

Create package in the same way above...

Possible Solution

No response

Additional Context

No response

stefanpejcic commented 1 month ago

Hmm, problem appears to be in image name, Can you share output of: opwncli plans-list

stefanpejcic commented 1 month ago

Was the plan created from gui or terminal? What did you use as docker image value?

caesarmind commented 1 month ago
Screenshot 2024-10-23 at 00 51 34

Actually I use basic and deluxe packages in production. they have apache + mariadb combination.

So, to replicate it on your own, try to create apache + mariadb plan with the same name

As I said, I think these two are connected: https://github.com/stefanpejcic/OpenPanel/issues/230

stefanpejcic commented 1 month ago

Plan name Has nothing to do, its escaped iin quotes so it Can be any value, cant really mess things up

I manage to reproduce only if i set custom image name to None when creating plan, in all other cases its using the image name set from GUI

stefanpejcic commented 1 month ago

Wait, Are those renamed plans, ot created?

If they were created on Enterprise, ID would start from 5 not 4

And if they were created on Community, then i dont see any issue, docker images with MariaDB are not available

Please provide steps to reproduce this on demo site

caesarmind commented 1 month ago

It happens on Enterprise edition. Okay, I found how to reproduce it.

FIrst create package on Enterprise edition. Then try to rename it, in rename window there is not apache/mariadb to choose, so as far is it can't find it it sets to "none".

P.S Yes those packages were created on Enteprise. So, I don't know "If they were created on Enterprise, ID would start from 5 not 4" how buletproof it is.

stefanpejcic commented 1 month ago

reproduced, removed the selection from edit-plan modal, it will now perserve existing image. 2024-10-23_12-44

adding to update