search

stefanpenner / broccoli-concat-analyser

MIT License
126 stars 14 forks source link

Return valid HTML #30

Closed simonihmig closed 6 years ago

simonihmig commented 6 years ago

Browsers are forgiving, but we should nevertheless return valid HTML! ;)

simonihmig commented 6 years ago

Failing due to https://github.com/zrrrzzt/html-validator/issues/87...

simonihmig commented 6 years ago

This is passing now, thanks to the lib supporting node 6 now. Though I had to add another commit to switch to node 6 in tests, and drop node 4. Which would require just another major version bump, but I guess we should do that anyways. @stefanpenner agree?

stefanpenner commented 6 years ago

100% down with dropping node 4 for this lib

stefanpenner commented 6 years ago

Good catch, thank you sir.

stefanpenner commented 6 years ago

released as v4.1.0 🎉