search

stefanpenner / broccoli-concat-analyser

MIT License
126 stars 14 forks source link

Expose createOutput function #31

Closed simonihmig closed 6 years ago

simonihmig commented 6 years ago

This exposes a public createOutput function (for external consumption, e.g. addon), that returns the content of the final single-file output (as cli.js was doing it).

stefanpenner commented 6 years ago

released as v4.1.0 🎉

simonihmig commented 6 years ago

released as v4.1.0

@stefanpenner shouldn't this has been 5.0.0, as we dropped node 4 here: https://github.com/stefanpenner/broccoli-concat-analyser/commit/429d8621adf06d1f1e64ebd06ab7bbb22781c8ba?

stefanpenner commented 6 years ago

hmmm. I think you are correct, but this library isn't SUPER critical. Do you think its ok if we leave it? I'll adjust according to your recommendation.

simonihmig commented 6 years ago

Yeah, I think this is mostly used manually from the CLI, where (I hope) nobody is using node 4 anyways. I am currently working on the stats addon we talked about a (long) while ago (man, time is flying!), and that's probably the only thing that is using this as a direct dependency!? So tl;dr I am fine with that! ;)

stefanpenner commented 6 years ago

@simonihmig thanks for all the help here man!