Closed simonihmig closed 6 years ago
@simonihmig sorry for the delay, I was on vacation. I left 1 comment, otherwise this looks good.
Could you also share before/after times for a medium sized app? I would like to be sure we are seeing some improvements.
sorry for the delay, I was on vacation
no need for excuses! 😉
Could you also share before/after times for a medium sized app?
I wrote that down, but unfortunately lost that note 🙄. IIRC it was around 2min vs. 50sec, but I will check again when I look at the exit code question (which is a valid concern!).
I wrote that down, but unfortunately lost that note 🙄. IIRC it was around 2min vs. 50sec, but I will check again when I look at the exit code question (which is a valid concern!).
As long as you did test it manually, thats good enough for me. I just wanted to be sure it did actually work (i expected it too).
@simonihmig LGTM, let me know if this is ready, i'll gladly merge + release.
@stefanpenner go for it! 🎉
released as v4.2.0 🎉
Closes #11
Worth noting:
summarize
function is not really working asynchronously, I nevertheless changed it also to return a Promise, so we can change the implementation a bit under the hood (like not using the...Sync()
node functions or so, if that makes sense)