stefanpenner / broccoli-concat-analyser

MIT License
126 stars 14 forks source link

Parallelism using workerpool #33

Closed simonihmig closed 6 years ago

simonihmig commented 6 years ago

Closes #11

Worth noting:

stefanpenner commented 6 years ago

@simonihmig sorry for the delay, I was on vacation. I left 1 comment, otherwise this looks good.

Could you also share before/after times for a medium sized app? I would like to be sure we are seeing some improvements.

simonihmig commented 6 years ago

sorry for the delay, I was on vacation

no need for excuses! 😉

Could you also share before/after times for a medium sized app?

I wrote that down, but unfortunately lost that note 🙄. IIRC it was around 2min vs. 50sec, but I will check again when I look at the exit code question (which is a valid concern!).

stefanpenner commented 6 years ago

I wrote that down, but unfortunately lost that note 🙄. IIRC it was around 2min vs. 50sec, but I will check again when I look at the exit code question (which is a valid concern!).

As long as you did test it manually, thats good enough for me. I just wanted to be sure it did actually work (i expected it too).

stefanpenner commented 6 years ago

@simonihmig LGTM, let me know if this is ready, i'll gladly merge + release.

simonihmig commented 6 years ago

@stefanpenner go for it! 🎉

stefanpenner commented 6 years ago

released as v4.2.0 🎉