breaking: bump terser

[lifeart]

because of differences in terser optimization logic (from v3 to v5), snapshots need to be changed, to simplify support, tests migrated to jest

dropped node 6, 8 support, new minimal version is 10

[lifeart]

I'm getting different stats in my local and in CI

and this is why CI is failing..

[rwjblue]

Generally speaking, all of these things should be separate PRs:

• snapshots need to be changed, to simplify support, tests migrated to jest
• dropped node 6, 8 support
• update terser

I don't have commit/release here, so I'll leave it to @stefanpenner / @simonihmig on how to proceed.

[simonihmig]

@lifeart thanks for working on this!

Generally speaking, all of these things should be separate PRs:

Generally speaking, I would agree! 😝 Alex, would you mind splitting this up? I guess bumping terser (with the changed test date) would come last, so you can use jest snapshots without having to manually update the text fixtures. At least that's why you wanted to introduce jest here mainly, right?

I'm getting different stats in my local and in CI

My best guess would be that it could be related to line endings, as the numbers are quite close, and only the "raw" numbers diverge. I guess you are running this on Windows, right?

[lifeart]

@rwjblue, @simonihmig thank you for feedback, yeah I think I will try to split it to: jest, node, terser mr’s

And yes, I’m running tests and snapshots on windows

[lifeart]

@stefanpenner, @simonihmig

1.) https://github.com/stefanpenner/broccoli-concat-analyser/pull/53 2.) https://github.com/stefanpenner/broccoli-concat-analyser/pull/54 3.) https://github.com/stefanpenner/broccoli-concat-analyser/pull/55 4.) https://github.com/stefanpenner/broccoli-concat-analyser/pull/56 (optional)