stefanpenner / ember-browsery-stats

MIT License
60 stars 7 forks source link

Fixed the typo on the installation command #3

Closed sivakumar-kailasam closed 9 years ago

kimroen commented 9 years ago

I actually think maybe the name of the addon on npm (and in the package.json) might be the actual typo, but this is actually the name of the addon on there indeed.

sivakumar-kailasam commented 9 years ago

@kimroen except for this repo's name, the published addon and the package.json both uses this term.

https://www.npmjs.com/package/ember-browsery-stats https://github.com/stefanpenner/ember-browser-stats/blob/master/package.json#L2

kimroen commented 9 years ago

Yes, but the initializer uses ember-browser-stats. Both the published addon name and the name in package.json is created by the same command (npm init), so it's more likely that this one is the typo.

Either way though, the name is the name, so @stefanpenner will just have to pick one - most likely ember-browsery-stats, as about 80 people have installed it already :)

sivakumar-kailasam commented 9 years ago

I'm happy as long as all the names are in sync :smiley:

stefanpenner commented 9 years ago

haha this is totally a typo, the question is should it remain?

kimroen commented 9 years ago

And then you have a third one ember-memory-stats in the readme, so who knows at this point ^^

Going with ember-browsery-stats is easiest, but if you're ever going to rename, then this is probably the time to do it. Can you redirect an npm-package?

stefanpenner commented 9 years ago

oh man, this is a funny bug.

ember-browsery-stats it is!

stefanpenner commented 9 years ago

@sivakumar-kailasam thanks for pointing all this out, i feel silly.

kimroen commented 9 years ago

This is the best.

sivakumar-kailasam commented 9 years ago

@stefanpenner happens :smile: