search

stefanpenner / es3-safe-recast

22 stars 11 forks source link

Publish a version of this package that doesn't depend on a github version of esprima@1.1.0-dev-harmony #16

Open Earthstar opened 9 years ago

Earthstar commented 9 years ago

I am not able to install a package that depends on es3-safe-recast because the published version of es3-safe-recast@1.0.0 depends on esprima@1.1.0-dev-harmony (git+https://github.com/thomasboyt/esprima.git#4be906f1abcbb6822e33526b4bab725c6095afcd). I request that you publish a version that doesn't depend on a git repo.

stefanpenner commented 9 years ago

@Earthstar want to submit a PR with a working esprima ? I'll merge and publish quickly if you can.

Earthstar commented 9 years ago

It looks like the version of es3-safe-recast@1.0.0 in the npm repository has different dependencies than the current master HEAD.

Running

$ npm view es3-safe-recast@1.0.0 dependencies

shows the problematic dependency, but running

$ npm list

from the es3-safe-recast project does not. So, simply publishing a new version of the project as-is would work.

Incidentally, I was able to solve my previous problem by upgrading a dependency version.

stefanpenner commented 9 years ago

I'll publish late tonight when I'm home. If it's not published by tomorrow feel free to remind me