search

stefanpenner / hash-for-dep

7 stars 11 forks source link

Fix throwing error if no main entry is defined #23

Closed topaxi closed 8 years ago

topaxi commented 8 years ago

Fixes #22

stefanpenner commented 8 years ago

test failures appear unrelated, will investigate shortly.

topaxi commented 8 years ago

Looks like nvm install failed on macosx, causing the tests to fail. Maybe restarting the tests might fix it?

maherbeg commented 8 years ago

Any updates here?

stefanpenner commented 8 years ago

@maherbeg test failures need investigation, just as it was earlier. If you have cycles, a hand here would be appreciated.

shaunc commented 8 years ago

Just hit this upstream: https://github.com/babel/broccoli-babel-transpiler/issues/72

I cloned and ran tests in node 0.12.4 in macosx 10.11.3 locally. I think the test failure was a travis glitch -- perhaps just try restarting test?

Would be great to get in -- shrinkwrap is such a pain :)

stefanpenner commented 8 years ago

kicking travis

topaxi commented 8 years ago

Still failing with /Users/travis/build.sh: line 45: nvm: command not found on the macosx builds. I sadly have no experience on travis with macosx at all.

stefanpenner commented 8 years ago

feel free to disable those OSX runs in the travis.yml, and we can merge. I don't really see value is linux + OSX tests for this project. Both should be sufficiently similar.

topaxi commented 8 years ago

Alright, I've removed osx from travis.yml. Tests are now passing :)

shaunc commented 8 years ago

LGTM ... though I admit a certain partisanship ;)

stefanpenner commented 8 years ago

thanks all

➜  hash-for-dep git:(master) git tag v1.0.2
➜  hash-for-dep git:(master) git push origin v1.0.2
Total 0 (delta 0), reused 0 (delta 0)
To git@github.com:stefanpenner/hash-for-dep.git
 * [new tag]         v1.0.2 -> v1.0.2
➜  hash-for-dep git:(master) npm publish
+ hash-for-dep@1.0.2