search

stefanpenner / hash-for-dep

7 stars 11 forks source link

fix broken symlinks error regression #60

Closed kellyselden closed 5 years ago

kellyselden commented 5 years ago

Scenario: You have an addon with a checked-in symlink "some-file => node_modules/some-package/some-file". Your app tries to link to a git branch of your addon. Depending on how npm or yarn structures the node_modules tree, the symlink may be broken. v1.5.0 version of hash-for-dep throws when v1.2.3 didn't.

This is borrowing the code from https://github.com/broccolijs/broccoli-kitchen-sink-helpers/blob/v0.3.1/index.js#L50-L63 that was in use in v1.2.3.

It is not ideal that we have projects with checked-in symlinks, but nevertheless, this fixes the regression.

stefanpenner commented 5 years ago

released as v1.5.1 🎉

kellyselden commented 5 years ago

Thanks @stefanpenner!

stefanpenner commented 5 years ago

thanks for catching.