search

stefanprodan / WebApiThrottle

ASP.NET Web API rate limiter for IIS and Owin hosting
MIT License
1.28k stars 274 forks source link

asp.net core package #65

Closed sANDwORm closed 8 years ago

stefanprodan commented 8 years ago

I'm developing this in a different project, the new rate limiter deals with various limitations that WebApiThrottle has. KestrelRateLimit is almost done, take a look here: https://github.com/stefanprodan/KestrelRateLimit

sANDwORm commented 8 years ago

Oh, that's great. Looking forward it.

sANDwORm commented 8 years ago

I am just looking on your project and it looks great.

I am just starting with .net core so please excuse my ignorance but I would recommend not to use "ILoggerFactory loggerFactory" in constructor with following loggerFactory.CreateLogger and switch to "ILogger logger" and let DI to deal with it?

Cheers, Roman

2016-07-26 16:22 GMT+02:00 Stefan Prodan notifications@github.com:

I'm developing this in a different project, the new rate limiter deals with various limitations that WebApiThrottle has. KestrelRateLimit is almost done, take a look here: https://github.com/stefanprodan/KestrelRateLimit

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stefanprodan/WebApiThrottle/issues/65#issuecomment-235282936, or mute the thread https://github.com/notifications/unsubscribe-auth/AE77ogh0b7AXA1EA8kRtjcRW9dqIv7gHks5qZhgegaJpZM4JVMRd .

stefanprodan commented 8 years ago

Good point, I was trying to implement a custom logger like in WebApiThrottle but I find it redundant. I forgot to change back to ILogger.

Thanks