stefanprodan / hrval-action

Flux Helm Release validation GitHub action
Apache License 2.0
60 stars 44 forks source link

Add Ability to Clone Private Charts Repos #15

Closed stevenpall closed 4 years ago

stevenpall commented 4 years ago
stevenpall commented 4 years ago

I think the push-container job needs a conditional to only run on pushes to master, otherwise PRs will fail:

on:
  push:
    branches:    
      - master
stefanprodan commented 4 years ago

I’ll have to fix the CI and make the container push only for master branches and tags.

edshelton commented 4 years ago

This does not account for cases where the ssh:// prefix is not included in the HelmRelease manifest (because it isn't required).

e.g.

spec:
  chart:
    git: git@github.com:my-org/my-helm-charts
    path: my-chart
    ref: master
stevenpall commented 4 years ago

@edshelton This should just work. The only thing we're doing here is substituting ssh:// for git@. Is it not working for you?

edshelton commented 4 years ago

The 's/ssh:\/\/git@//' sed expression is removing the entire ssh://git@ prefix, not just ssh://. If you only have git@ in your HelmRelease, this won't remove that prefix because it doesn't start with ssh://. My latest PR separates the two :)