Closed stevenpall closed 5 years ago
I think the push-container
job needs a conditional to only run on pushes to master, otherwise PRs will fail:
on:
push:
branches:
- master
I’ll have to fix the CI and make the container push only for master branches and tags.
This does not account for cases where the ssh://
prefix is not included in the HelmRelease manifest (because it isn't required).
e.g.
spec:
chart:
git: git@github.com:my-org/my-helm-charts
path: my-chart
ref: master
@edshelton This should just work. The only thing we're doing here is substituting ssh://
for git@
. Is it not working for you?
The 's/ssh:\/\/git@//'
sed expression is removing the entire ssh://git@
prefix, not just ssh://
. If you only have git@
in your HelmRelease, this won't remove that prefix because it doesn't start with ssh://
. My latest PR separates the two :)
$GITHUB_TOKEN
environment variable exists (personal access token) and if it does, use it to clone private charts repos