search

stefanprodan / hrval-action

Flux Helm Release validation GitHub action
Apache License 2.0
60 stars 44 forks source link

support authenticated chart repositories #24

Closed omerlh closed 4 years ago

omerlh commented 4 years ago

Currently, there is no way to test HelmRelease when the release is pointing to an authenticated cart repository. This is because the helm repo add line, that is failed if the repo is authenticated.

stefanprodan commented 4 years ago

You need to provide a GitHub token for private repos as described here https://github.com/stefanprodan/hrval-action#usage-with-private-charts-repositories

omerlh commented 4 years ago

The repo is stored on Azure ACR - using GitHub token will not help in this case...

omerlh commented 4 years ago

I solved it by running helm repo add myself just before running the tests. There is an error when hrval trying to add the repo, but it does not fail the tests.

stefanprodan commented 4 years ago

I think we can improve this and run helm repo add only if the repo URL is not in repositories.yaml. I also think we should add a private repo example to the docs.