Closed adampeklay closed 4 years ago
putting this PR into draft mode, forgot to add the repo & run repo update
My notes from my step before that didn't end up working out (also realized I setting a env var for region would be cleaner).
- name: Install Helm S3 plugin, add example-helm-repo
shell: bash
run: |
mkdir ~/.aws
cat << EOF > ~/.aws/config
[default]
region = us-east-1
EOF
helm plugin install https://github.com/hypnoglow/helm-s3.git
helm repo add example-helm-repo s3://example.com/charts
helm repo update
I'll get around to that soon
@stefanprodan I think we may be good to go now.
Perhaps you want to create a draft GithHub Marketplace listing? I was reading up on how to test GitHub Marketplace listings , I didn't want to try to create a draft of this and accidentally step on anyones toes, so to speak.
If you do not wish to include AWS S3 Helm repo functionality that is OK, I can use my fork of your repo and create a new iteration of this for GitHub Marketplace.. of course giving you proper credit for your work!
Let me know what you think about this please, Thank you!
@stefanprodan: Done! Sorry that took a while, I didn't see this until today. Haven't squashed from the command line in a while, had to refresh on that!
hrval-action needs aws s3 helm repo support
Purpose
I added a step before "Validate Helm Release from Helm Repo" to install helm s3 plugin but the step "Validate Helm Release from Helm Repo" overwrites my changes, so the main code needs to be updated AFAIK.
Changes:
I'm new to GH actions however I think I did this right. Please feel free to suggest changes or make changes as you see fit to make this work. Changes can be seen in "files changed" tab.
Tests:
I did not test this, I only tested my first approach listed in the purpose section and that failed miserably.
Launch Plan:
code owner merges