stefanprodan / hrval-action

Flux Helm Release validation GitHub action
Apache License 2.0
60 stars 44 forks source link

Add support for sourcing chart from head ref when testing pull request #38

Closed mksh closed 4 years ago

mksh commented 4 years ago

This is based on https://github.com/stefanprodan/hrval-action/pull/33 and intended to solve the same problem.

How to clone a right helm chart source in the case when helm chart referenced in a helm release being tested by hrval-action is located in the same git repository, where hrval-action is run ?

In case of pull request, if a pull request base repository branch is referenced in helm release, hrval-action might be executed against invalid version of helm chart source, other than one contained in head repository branch.

Algorithm:

This patch is non-intrusive, and a pre-patch behavior will be executed in case if HRVAL_BASE_BRANCH and HRVAL_HEAD_BRANCH variables are not set.

mksh commented 4 years ago

Sure, have added documentation for this feature to Readme