search

stefanprodan / hrval-action

Flux Helm Release validation GitHub action
Apache License 2.0
60 stars 44 forks source link

fixed broken install in docker file #52

Closed maorgoldberg closed 3 years ago

maorgoldberg commented 3 years ago

Fixed issue that caused curl version to break the docker file by updating its version.

maorgoldberg commented 3 years ago

Removing version pinning causes checks to fail

stefanprodan commented 3 years ago

That lint rule is kinda silly, we need to remove it.

maorgoldberg commented 3 years ago

Yea I'll take a look at the linting action and add an ignore for it and create a separate pr for it. However this one should fix dockerfile errors without issue regardless of the failed lint

stevenpall commented 3 years ago

Could we please get a new release cut that includes this fix? We try not to use @master.

maorgoldberg commented 3 years ago

Could we please get a new release cut that includes this fix? We try not to use @master.

Is an action needed on my part?

stevenpall commented 3 years ago

Could we please get a new release cut that includes this fix? We try not to use @master.

Is an action needed on my part?

Nope, all good now. The v3.5.0 release includes this fix. Thanks!