Closed stephenmoloney closed 5 years ago
Isn't this part of #40 ? If so please close this one and rebase #40
Isn't this part of #40 ? If so please close this one and rebase #40
@stefanprodan those are separate PRs. I'm not 100% it's (#40) entirely needed - I was using it to see if the problem was with the kernel when debugging so made a PR. I put it in a separate PR for separate review.
I'd like to see this one merged though (#39) once I've finished testing it and you have reviewed it.
TLDR; I'd like to keep them separate for easier review purposes.
Note: Pending merge of #38 in the first instance.
What does this commit/MR/PR do?
Easier terraform choice of docker and ubuntu versions
Allows Ubuntu Bionic Beaver and Xenial to be chosen as os
Allows different docker image to be chosen for k8s cri
Why is this commit/MR/PR needed?
More configurability in tf vars
Testing carried out as follows:
arch: arm k8s_version: 1.12 os: Ubuntu Xenial
arch: arm k8s_version: 1.12 os: Ubuntu Bionic
This combination (k8s 1.12, arm, Ubuntu Bionic) fails due to the
kubernetes/kubeadm/issues/413
despite having a longinitialDelaySeconds
. Noted in the docs to thatUbuntu Bionic
not working with arm - https://github.com/stefanprodan/k8s-scw-baremetal/pull/39/files#diff-c9ac8098c5ea9d3e6a9a596ff0c512a4R14.arch: x86_64 k8s_version: 1.12 os: Ubuntu Bionic