[WIP] Allow specification of the bootscript

stefanprodan / k8s-scw-baremetal

Kubernetes installer for Scaleway bare-metal AMD64 and ARMv7

MIT License

177 stars 58 forks source link

Open stephenmoloney opened 5 years ago

stephenmoloney commented 5 years ago

What does this commit/MR/PR do?

Allow specification of the bootscript
Remove the unused additional volume - those aren't needed with baremetal servers

Why is this commit/MR/PR needed?

stephenmoloney commented 5 years ago

I would prefer this feature to be entirely optional and be a null terraform variable by default.

Terraform 12 when released will support this and I think it's a good way to go. See hashicorp/terraform/issues/14037#issuecomment-433569957

It would require changing terraform to

terraform {
  required_version = ">= 0.12"
}

once it's released that is.

I'll put this on hold for now.