stefanprodan / podinfo

Go microservice template for Kubernetes
Apache License 2.0
5.35k stars 1.7k forks source link

feat(chart): allow input config and extraArgs #344

Closed toyamagu-2021 closed 5 months ago

toyamagu-2021 commented 6 months ago

Signed-off-by: toyamagu2021 toyamagu2021@gmail.com

Motivation

Modification

Verification

config:
  path: "."
  name: "config.yaml"
$ helm template . -s templates/deployment.yaml
          command:
            - ./podinfo
            - --port=9898
            - --cert-path=/data/cert
            - --port-metrics=9797
            - --grpc-port=9999
            - --grpc-service-name=podinfo
            - --level=info
            - --random-delay=false
            - --random-error=false
            - --config-path=.
            - --config=config.yaml
extraArgs:
- --test=test
$ helm template . -s templates/deployment.yaml
          command:
            - ./podinfo
            - --port=9898
            - --cert-path=/data/cert
            - --port-metrics=9797
            - --grpc-port=9999
            - --grpc-service-name=podinfo
            - --level=info
            - --random-delay=false
            - --random-error=false
            - --test=test
mhulscher commented 5 months ago

I am looking for this functionality as well :) Is there anything preventing this from being merged?

stefanprodan commented 5 months ago

@toyamagu-2021 can you rebase with master and resolve the conflicts please

toyamagu-2021 commented 5 months ago

@stefanprodan thanks! rebased