search

stefanprodan / podinfo

Go microservice template for Kubernetes
Apache License 2.0
5.4k stars 1.72k forks source link

GRPC Apis for Corresponding HTTP APIs #369

Closed Prashant-Dwivedi-08-01 closed 4 months ago

Prashant-Dwivedi-08-01 commented 5 months ago

Hey @stefanprodan This PR is in the continuation of our previous effort to include the gRPC APIs for podinfo to extend it's application. Previous Approved PR: https://github.com/stefanprodan/podinfo/pull/322 We introduced few APIs last time to test the stability of Podinfo with those. Now we are ready with remaining set of APIs.

Please have a look at this PR that includes the remaining set of APIs. Thank You

Fix: #318

Prashant-Dwivedi-08-01 commented 4 months ago

@stefanprodan As per your comment, I have added description of all the gRPC APIs in the main README, you can review it once. Apart from this, I have a request that if you can look once into why one of the checks is failing in GitHub Actions. I am getting this error "no language version declared in module.cue" under "Verify CUE formatting". It asks for adding the language version, but I am not sure why we should edit module.cue file. Linking it here directly: https://github.com/stefanprodan/podinfo/actions/runs/9631176029/job/26562620984

Please see if you can help. Thanks

stefanprodan commented 4 months ago

Please rebase with the master branch, CI should be fixed.

Prashant-Dwivedi-08-01 commented 4 months ago

@stefanprodan thanks for that recommendation. CI is fixed. You can consider reviewing once and approving the PR. Thanks

stefanprodan commented 4 months ago

Can you please run go fmt ./... and commit any changes.

Prashant-Dwivedi-08-01 commented 4 months ago

Can you please run go fmt ./... and commit any changes.

@stefanprodan did that!