stefanprodan / swarmprom

Docker Swarm instrumentation with Prometheus, Grafana, cAdvisor, Node Exporter and Alert Manager
MIT License
1.87k stars 733 forks source link

Added CPU limits / Update RAM limits #92

Closed pascalandy closed 5 years ago

pascalandy commented 5 years ago

Details: https://github.com/stefanprodan/swarmprom/issues/91

stefanprodan commented 5 years ago

I think all components should have at least 512M limits except Prom that should have at least 2G. As for the CPU usage except cAdvisor I would not set any limits. It's up to the user to decide that, if you have a large cluster, the current limits in this PR will make the whole monitoring system freeze.

pascalandy commented 5 years ago

Agree to disagree. I run a 3 node cluster. You are right that my values might be too conservative for bigger loads.

My goal was to be able to follow the update of this project without having to modify the limit on my side. I'll drop it.