search

stefanprodan / timoni

Timoni is a package manager for Kubernetes, powered by CUE and inspired by Helm.
https://timoni.sh
Apache License 2.0
1.51k stars 67 forks source link

[Proposal] Replace --debug with --file for vet #288

Closed b4nst closed 8 months ago

b4nst commented 8 months ago

Currently the vet command only accepts a --debug boolean argument to be able to vet the module against debug_values.cue file. I find this file quite confusing, and often removes it all together with the debug_tool.cue. I think it would be useful for the vet command to take a --values (or --value if we want to keep it simple) argument, and vet against those(this) values file(s).

It would help us testing complex module where there's mutually exclusive configuration value (cloud provider for example).

What do you think @stefanprodan? If ok with you I can push a PR

stefanprodan commented 8 months ago

I'm Ok adding -f, --values strings same as the for the timoni build command. I'm using --debug in lots of places, so please leave that as it is, if custom values are provided, those would take precedence over debug.

b4nst commented 8 months ago

Copy, thanks! Will push you a MR later today