search

stefanprodan / timoni

Timoni is a package manager for Kubernetes, powered by CUE and inspired by Helm.
https://timoni.sh
Apache License 2.0
1.44k stars 64 forks source link

Refactor `cmd/timoni` and extract reconciler logic to dedicated package #366

Closed errordeveloper closed 3 weeks ago

errordeveloper commented 3 months ago

Towards: #10

errordeveloper commented 3 months ago

@stefanprodan I've rebased and made it green, there is still some work, but maybe woth a quick review whenever you have a chance?

stefanprodan commented 2 months ago

@errordeveloper looks great so far. Will you be adding deletion to the reconciler package?

errordeveloper commented 2 months ago

I can add deletion methods in this PR or leave for another one, what would you prefer?

stefanprodan commented 1 month ago

I can add deletion methods in this PR or leave for another one, what would you prefer?

I would leave it for another PR, this has lots of good things already, thank you!

errordeveloper commented 1 month ago

I would leave it for another PR, this has lots of good things already, thank you!

Ok, I have cleaned up most of the commits, just the last two need some attention. I can resolve sometime soon, but feel free to do it if you would like to merge. The revert commit needs to be drop with its original commit and the empty TODO commit would need to be dropped.

errordeveloper commented 4 weeks ago

...just the last two need some attention.

all done now!

errordeveloper commented 4 weeks ago

@stefanprodan should be good to merge now!