search

stefanradev93 / BayesFlow

A Python library for amortized Bayesian workflows using generative neural networks.
https://bayesflow.org/
MIT License
297 stars 45 forks source link

Regarding-your-joss-submission #96

Closed sandeshkatakam closed 1 year ago

sandeshkatakam commented 1 year ago

Link to the joss review issue : https://github.com/openjournals/joss-reviews/issues/5702 This issue is regarding your submission of the software paper BayesFlow to JOSS. I was trying to run the tests you mentioned in the tests folder using pytest. I am encountering the error because of the pyproject.toml file(this line in particular --cov BayesFlow). Can you please look into it once and respond.

marvinschmitt commented 1 year ago

Thank you for opening this issue.

Could you please try to install pytest-cov for the coverage metrics and see whether that resolves the issue?

pip install pytest-cov

Thanks, Marvin

yannikschaelte commented 1 year ago

Hi @sandeshkatakam , the prerequisites for development should also be described here: https://bayesflow.org/contributing.html#environment

Specifically, running pip install -r requirements_dev.txt should install all necessary dependencies. @marvinschmitt it seems https://github.com/stefanradev93/BayesFlow/blob/Development/requirements_dev.txt could be updated, esp. to only require >= minimum versions?

stefanradev93 commented 1 year ago

I have updated requirements_dev.txt in Development to use at least the recent versions of the listed packages (>=) .

sandeshkatakam commented 1 year ago

Thank you. The tests are running fine now.