search

stefanseefeld / faber

Faber
https://stefanseefeld.github.io/faber
Boost Software License 1.0
14 stars 2 forks source link

Check c++ version based on msvc version #7

Open terrorfisch opened 6 years ago

terrorfisch commented 6 years ago

See #6

terrorfisch commented 6 years ago

Strange. The tests do not fail on my machine and dnot seem connected to the code changes.

stefanseefeld commented 5 years ago

I have rewritten the scheduler (using Python async), so these failures should be a thing of the past. I don't agree with this PR, though: While I understand that MSVC may actually support C++11 now, I think it's best to preserve the semantics of these specific checks. If that doesn't yield the information you want you may think of other checks that test specific C++ features, rather than only that version macro. Else we get into the muddy waters of having to decide what it actually means to support C++11, etc.