stefansenk / spree_multi_tenant

Adds multi-tenant support to Spree. Allows completely separate Spree sites with separate admins to be run from the same installation.
BSD 3-Clause "New" or "Revised" License
73 stars 43 forks source link

Should Spree::Role be a tenanted model? #12

Open eLafo opened 10 years ago

eLafo commented 10 years ago

I think that I am missing something because I do not get which the point is for Spree::Role to be a tenanted model

If I create a new Tenant, authorization will fail, since I need to create new roles for it. Maybe I am missing something, but I think that roles should be the same for all the tenants unless they are customizable by tenant, which they are not, right now, aren't they?

fattymiller commented 10 years ago

I like the idea of separating the roles based on shops as this will allow different shops to have their own roles without needing to jump through hoops to fit in to a previously defined model.

New shop setups can be a pain, but this can be easily corrected by creating a default set of Roles upon Shop creation, and then allow the shop owner to make changes at their leisure.