Fixed invalid-token related issues

stefansundin / traceroute-mapper

Map your traceroutes easily.

https://stefansundin.github.io/traceroute-mapper/

GNU Affero General Public License v3.0

286 stars 27 forks source link

Fixed invalid-token related issues #5

Closed dacrystal closed 4 years ago

dacrystal commented 4 years ago

Ignore/hide the error message as the error already have been handled
Fixed draw line funciton when there are multipe hops with no location(discrete points)

stefansundin commented 4 years ago

Thanks, but I already had a fix for this, but I just hadn't pushed it yet. Fixed in 83bbf33b837e1f2a0d5e58c3ba6a86fb10592fdc.

~~Can you elaborate on Fixed draw line funciton when there are multipe hops with no location(discrete points)? Is that the change from 9 to 99?~~

Edit: I guess it's this:

hosts = hosts.filter( host => db[host.ip])

I missed this line on my first look. Can you give me a good trace to show that on the map, and I can add that to the code?

dacrystal commented 4 years ago

See the below example of 5 hops with know location for the first and last nodes. The draw function will draw marks with not lines between them. Because the function only draw line between adjacent points with locations (1-2, 2-3, 3-4, 4-5).

1  lc207-gw.campus.ltu.se (130.240.207.1)  0.219 ms
2  192.168.1.1 (192.168.132.1)  4.455 ms
3  192.168.1.1 (192.168.132.1)  4.455 ms
4  192.168.1.1 (192.168.132.1)  4.455 ms
5  210.74.176.238 (210.74.176.238)  428.721 ms

In 83bbf33 I would advise to let 'ipinfo' do the filtering for you. That's way you don't care if the IP is private or not (it could be a public IP without permission to view it's geolocation).

stefansundin commented 4 years ago

Thanks. I fixed it in 932a5daa8f4c344f76f4f20e1ee6b55960b3ef04.

One reason why I decided to filter out RFC1918 ranges is to reduce rate limit usage (and RFC1918 is so easy to filter out). It seems a lot more complicated to do the same for IPv6, so I also decided to ignore the error message.