search

stefantalpalaru / w_scan2

w_scan fork (channel scan tool which generates ATSC, DVB-C, DVB-S/S2 and DVB-T/T2 channels.conf files)
GNU General Public License v2.0
81 stars 24 forks source link

Implemented XML export of transponder and channel list #32

Closed jmwislez closed 3 years ago

jmwislez commented 3 years ago

Full implementation of the XML export as per current transponder struct content and XML DTD. Tested on DVB-S/S2 (Astra 19.2E, Astra 23.5E, Astra 28.2E, Hotbird 13.0E, Eutelsat 5.0W) and XML validates.

stefantalpalaru commented 3 years ago

We need consistent indentation in our source files. A while ago, I settled on the Linux kernel rules for all the code: https://www.kernel.org/doc/html/v4.10/process/coding-style.html

While you figure out how to get your text editor to enforce those for you, feel free to run this script on the files you modify: https://github.com/torvalds/linux/blob/master/scripts/Lindent

Also, try looking into what changes the permissions of all the files you edit to 755.

jmwislez commented 3 years ago

I believe that with these commits, the points you made are now addressed. Any further concerns?

stefantalpalaru commented 3 years ago

Any further concerns?

No, I just need to find the time to review it.

jmwislez commented 3 years ago

No prob, take your time!

stefantalpalaru commented 3 years ago

Merged. Thanks!