search

stefanwalther / sense-export

Just a simple button to export data in your Qlik Sense applications.
Other
29 stars 27 forks source link

There is a bug in client side CSV export, function $scope.getAllData() #51

Open dariuspranskus opened 5 years ago

dariuspranskus commented 5 years ago

Hello

Description

There is a bug in client side CSV export code, specifically in $scope.getAllData() function. This causes some lines being omitted from the export for each 500 lines or so.

The incorrect line is line 153. I believe index should not be added while calculating qTop:

var page = {
    qTop: (pageHeight * index) + index, // +index should not be here
    qLeft: 0,
    qWidth: columns,
    qHeight: pageHeight,
    index: index
};

Steps to Reproduce

  1. Take any application which has more that 500 records
  2. Set the extension object up. Choose Comma separated CSV - Client side option
  3. Export the data using the extension
  4. Export the data using QlikSense native functionality
  5. Compare the results, specifically number of rows.
  6. See some records missing from the extension export.

Proposed solution

Remove + index from qTop value calculation.

Thanks

eagaratez commented 4 years ago

I also noticed the missing entries however I was suspecting that it was related to a 'for loop' gathering 499 values instead of 500 due to a < instead of a <=. I'm going to try your fix, thanks.

gepascual commented 4 years ago

Hi, I had the same problem. Is there a solution?

jbaberdc commented 1 year ago

Same here! Is there any resolution in the works for this? I see that this is a pretty old issue thread.