Unable to display other than General tab for version 1.0x

analienx commented 6 years ago

Description

After dragging the sense-tab object to the sheet only general tab is displayed. Valid for versions 1.0x, version 0.83 works just fine (yet there are security issues so we would like to go with the newest version that does not have the XSS vulnerabilities).

Steps to Reproduce

Drag the extension to the sheet

Expected behavior

See multiple tabs for extension config, not just general

Actual behavior

onlgz general tab

Environment

Operating system

Windows ``

Qlik Sense

Desktop



##### Browser
Chrome  { notapplicable

### Versions

* Extension version: 1.0xx
* Browser: 
* Qlik Sense:  two versions tried = 3.2.2 and November 17
* Operating system: 
Windows 2007

stefanwalther commented 6 years ago

Hi - with "tab" you mean the accordion in the property panel?

analienx commented 6 years ago

That is correct. Also console throws lot of errors

Sent from my Windows 10 phone

From: Stefan Walther notifications@github.com Sent: Saturday, April 28, 2018 10:58:03 PM To: stefanwalther/sense-navigation Cc: analienx; Author Subject: Re: [stefanwalther/sense-navigation] Unable to display other than General tab for version 1.0x (#142)

Hi - with "tab" you mean the accordion in the property panel?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/stefanwalther/sense-navigation/issues/142#issuecomment-385204976, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMV4Wgbnl1AZfHnjxRlIwmyefa0JObboks5ttNfbgaJpZM4TTXEw.

stefanwalther commented 6 years ago

Hi @analienx, it would be very helpful if you could post a screenshot of the errors here (or even better the full text of it)? Thx in advance. Stefan

JMHellendoorn commented 6 years ago

sense-navigation internet explorer 1 Please find attached a screenshot of the issue. I think this issue is the same as request #140. If so, it only happens in Internet Explorer.

stefanwalther commented 6 years ago

OK, yes, I definitely need to do some testing on IE ... ;-( ... unfortunately ...

analienx commented 6 years ago

Hi, It has never worked even in Chrome for us. The 2x version so the issue might be somewhere else

Sent from my emergency iPhone. Please forgive possible misspellings

From: Stefan Walther notifications@github.com Sent: Sunday, July 29, 2018 11:57 PM To: stefanwalther/sense-navigation Cc: analienx; Mention Subject: Re: [stefanwalther/sense-navigation] Unable to display other than General tab for version 1.0x (#142)

OK, yes, I definitely need to do some testing on IE ... ;-( ... unfortunately ...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/stefanwalther/sense-navigation/issues/142#issuecomment-408708753, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMV4Wr9k7Atio_nEyEo8wbl_4ZTrP5Sfks5uLi-sgaJpZM4TTXEw.

stefanwalther commented 6 years ago

Do you have the 0.8x version installed somewhat in parallel, or is it an app where you have used the old version, too? I am trying to reproduce the issue to be able to fix it.

stefanwalther commented 6 years ago

Could you pls open the Chrome Developer Tools Console and show me what's listed there, there must be some errors there I guess ... That would be super-useful.

analienx commented 6 years ago

Hello, That is correct, 0.8x version works without any issues. I'm afraid we removed the new version and left with the old one instead, let me check if it is on one of our environments

Sent from my emergency iPhone. Please forgive possible misspellings

From: Stefan Walther notifications@github.com Sent: Tuesday, July 31, 2018 12:08 AM To: stefanwalther/sense-navigation Cc: analienx; Mention Subject: Re: [stefanwalther/sense-navigation] Unable to display other than General tab for version 1.0x (#142)

Could you pls open the Chrome Developer Tools Console and show me what's listed there, there must be some errors there I guess ... That would be super-useful.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/stefanwalther/sense-navigation/issues/142#issuecomment-409027983, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMV4WvGCeOUOUP0CDbUPAvzQ1Xrt_mmWks5uL4POgaJpZM4TTXEw.

stefanwalther commented 6 years ago

So what are you saying? Both versions: v1.x and 0.8x are installed in parallel? How is this even possible? I guess, you are then using Desktop and not server and have just put the extensions side by side in different folders?

analienx commented 6 years ago

Hello, firstly there was never version then it was Uninstalled (removed) and replaced with older one. Not at the same time. Enterprise version,not desktop. November 17

Sent from my emergency iPhone. Please forgive possible misspellings

From: Stefan Walther notifications@github.com Sent: Tuesday, July 31, 2018 1:27 PM To: stefanwalther/sense-navigation Cc: analienx; Mention Subject: Re: [stefanwalther/sense-navigation] Unable to display other than General tab for version 1.0x (#142)

So what are you saying? Both versions: v1.x and 0.8x are installed in parallel? How is this even possible? I guess, you are then using Desktop and not server and have just put the extensions side by side in different folders?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/stefanwalther/sense-navigation/issues/142#issuecomment-409187483, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMV4WiM7JpT9C0pUT5bUKJOzdTHctxtTks5uMD8tgaJpZM4TTXEw.

stefanwalther commented 6 years ago

Hi @analienx, @JMHellendoorn , please try the new RC-03:

I found the error (fixed in #159):

In Qlik Sense Desktop and older browsers (like IE 11) JavaScripts const and let did not work, which actually broken the extension.
Fixed that now and tested in
- Qlik Sense Desktop June 2018 (inside the Desktop, not only using http://localhost:4848)
- Firefox
- Chrome
- Edge

Please give it a try and let me know. Thx a lot in advance!

JMHellendoorn commented 6 years ago

Thanks @stefanwalther The solution works now.

stefanwalther commented 6 years ago

Great, thx for notifying me. Then I can close this ... ;-)

stefanwalther / sense-navigation