search

stefanwille / crystal-redis

Full featured Redis client for Crystal
MIT License
381 stars 61 forks source link

Allows `#del` to receive a `Array(RedisValue)`. #105

Closed rodrigopinto closed 3 years ago

rodrigopinto commented 4 years ago

This PR is for allowing the method #del to receive an Array(RedisValue) and perform the deletes properly.

Issue:

When performing a search with the method #keys, it returns a list of keys as Array(RedisValue) and when trying to pass the returned array to the method #del it fails.

On the issue #100 I mentioned about the changing the return of the methods keys, but at looking into the API of the lib, it did not make sense as the issue was on a private method that required a simple overload and a internal casting of the keys to String as per redis implementation, the keys are binary-safe strings.

This PR fixes #100

rodrigopinto commented 4 years ago

Hey @stefanwille, it seems you hadn't the proper time yet to look into the recent PR's. This one closes the issue 100 and the PR 101 and allows two other projects move forward.

Additionally, If I can support you with this shard, let me know.

Thanks for the hard work.

kostya commented 3 years ago

this is in some way in master.