search

stefanwille / crystal-redis

Full featured Redis client for Crystal
MIT License
381 stars 61 forks source link

hmget could return a future #95

Closed vince94320 closed 4 years ago

vince94320 commented 4 years ago

Not sure If this is required, but I ended to have some failing tests in sidekiq.cr because it uses pipelined calls with hmget and they should return a Redis::Future

stefanwille commented 4 years ago

Hi Vince, yes, this is a bug. The fix is different though: commands.cr relies on type inference from the underlying command_execution to get the return types. I have put a fix in https://github.com/stefanwille/crystal-redis/commit/d65deaeecb63fa40b91fa7bec70c028a4a4e7b92

Thank you for your effort.

stefanwille commented 4 years ago

Closing in favor of https://github.com/stefanwille/crystal-redis/commit/d65deaeecb63fa40b91fa7bec70c028a4a4e7b92