search

stefanzweifel / git-auto-commit-action

Automatically commit and push changed files back to GitHub with this GitHub Action for the 80% use case.
MIT License
2.06k stars 231 forks source link

Node.js 12 actions are deprecated #246

Closed SevereCloud closed 2 years ago

SevereCloud commented 2 years ago

git-auto-commit Version

v4.15.0

Machine Type

Ubuntu (eg. ubuntu-latest)

Bug description

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: stefanzweifel/git-auto-commit-action

Steps to reproduce

Run and see annotations

Tried solutions

No response

Example Workflow

-

Relevant log output

No response

stefanzweifel commented 2 years ago

Thanks for bringing this up. Will push an update in the next few hours.

stefanzweifel commented 2 years ago

Fixed in v4.15.1: https://github.com/stefanzweifel/git-auto-commit-action/releases/tag/v4.15.1

lukasz-mitka commented 2 years ago

@stefanzweifel I advice doing a major release instead and pointing v4 tag back to v4.15.0 Node upgrade can brake this action for GHES that haven't upgraded yet.

stefanzweifel commented 2 years ago

@lukasz-mitka I thought about doing that. Decided against it, as this Action uses node.js only to execute the shell script: https://github.com/stefanzweifel/git-auto-commit-action/blob/master/index.js#L27

By releasing a new major version, thousands of workflows also have to be updated. Dependabot sometimes takes care of this, but not always (?). Not sure if it's worth the trouble. 🤔

I guess you run GHES and run into this issue? Maybe I could also point v4 back to v4.15.0 and wait a month or so, until the majority of GHES users have updated? (I have no clue how GHES works)