search

stefanzweifel / git-auto-commit-action

Automatically commit and push changed files back to GitHub with this GitHub Action for the 80% use case.
MIT License
2.01k stars 228 forks source link

Update default email address of github-actions[bot] #264

Closed Teko012 closed 1 year ago

Teko012 commented 1 year ago

GitHub uses the new email format by default at commits when the github-actions[bot] is being used. This should bring it inline with that.

stefanzweifel commented 1 year ago

Thanks! I will take a closer look later today.

Teko012 commented 1 year ago

Originally there were two reasons why I started looking into this: some of the commits made by actions were Co-authored-by by the action itself (with the old email format), and it also showed up as github-actions[bot] and github-actions[bot] committed. I looked at git log, and I noticed that the actual commit author email was the one with the ID included.

If you look at the API, the user was created on 2018-07-30T09:30:16Z, a year after they started using their new format. You can also see the id there.

So I think the right email to use would be the one with the ID, but you could double check it of course to see if you see the same behaviour in workflows, just to make sure :)

stefanzweifel commented 1 year ago

Thanks for the explanation. I think that make sense to merge this PR and align it the behaviour of this Action with the "pattern" GitHub uses for the noreply-email adresses for GitHub accounts.

Will merge this to master now and tag a new version in the next couple of days. Some people are using main in their workflows. Maybe some users will report weird behaviour because of this (probably not but you never know)