Laravel Analyzer

[stefanzweifel]

This pull request includes changes and recommendations for crafting your application "The Laravel Way". Feel free to commit any additional changes to the shift-8235 branch.

Before merging, you should:

• Checkout the shift-8235 branch
• Review all pull request comments for additional changes
• Thoroughly test your application

If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

[stefanzweifel]

⚠ The following files reference Laravel facades through the global namespace. For example, you're referencing \DB or importing use DB;. Instead import Illuminate\Support\Facades\DB and reference DB.

While global references are allowed through aliases, you should import the facade explicitly. This can improve clarity not only for developers, but static analysis used by your IDE.

• [ ] app/Http/Controllers/Auth/RegisterController.php

[stefanzweifel]

⚠ Shift found inline validation in the following controllers. Unless you require this level of control, you should use a Form Request to encapsulate this validation logic and keep your controller clean.

• [ ] app/Http/Controllers/Auth/RegisterController.php

[stefanzweifel]

⚠ Shift found opportunities to use the built-in Blade directives like @csrf, @json in the following views:

• [ ] resources/views/auth/login.blade.php
• [ ] resources/views/auth/passwords/email.blade.php
• [ ] resources/views/auth/passwords/reset.blade.php
• [ ] resources/views/auth/register.blade.php
• [ ] resources/views/layouts/_head.blade.php
• [ ] resources/views/layouts/_navigation.blade.php

[stefanzweifel]

ℹ Your Laravel application contains 69 classes and 688 lines of code, with an average of 2.72 lines of code per method.

Most of your classes are Controllers. Your Controllers contain the most lines of code (126 loc) and your Controllers have the highest lines of code per method (5.04 loc).

[stefanzweifel]

⚠ Shift found the following config files differ from the defaults. While you are welcome to customize your configuration, you should leverage ENV variables rather than hardcode values. If you find you're adding a lot of configuration options, consider creating a domain specific config file, such as core.php. Both will make app upgrades and deployments easier.

• [ ] config/app.php
• [ ] config/auth.php
• [ ] config/filesystems.php
• [ ] config/mail.php
• [ ] config/services.php

[stefanzweifel]

ℹ Shift noticed you have additional namespaces in your project. You should consider using the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel App namespace.

[stefanzweifel]

ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel.