stefanzweifel / screeenly

📸 Screenshot as a Service
https://secure.screeenly.com
MIT License
496 stars 102 forks source link

Laravel 5.8 Shift #231

Closed stefanzweifel closed 5 years ago

stefanzweifel commented 5 years ago

This pull request includes the changes for upgrading to Laravel 5.8. Feel free to commit any additional changes to the shift-13083 branch.

Before merging, you should:

If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

stefanzweifel commented 5 years ago

:x: Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.8 configuration files and merge any changes:

stefanzweifel commented 5 years ago

:warning: Laravel 5.8 introduced a set of AWS environment variables to help consolidate configuring the various AWS services. You should rename the following native environment variables to their new names. While you don't have to rename any custom environment variables you created for AWS services, you should consider following the new naming convention.

stefanzweifel commented 5 years ago

:x: Laravel 5.8 has a dependency for php of ^7.1.3. You have a modified dependency for php in your composer.json. You should review your dependency and ensure it meets the new version requirement.

stefanzweifel commented 5 years ago

:warning: Laravel 5.8 changed several of the core contracts with new implementations and methods. You should review the Upgrade Guide for more detail on these respective changes:

Shift found references to these contracts within:

stefanzweifel commented 5 years ago

:information_source: Laravel 5.8 changed the minimum requirement for password length from 6 characters to 8 character. While this change is not required, you should consider this opportunity to review the password policy for your application.

stefanzweifel commented 5 years ago

:warning: If you are using JSON values in your MySQL or MariaDB tables, the query builder now returns unquoted JSON values in Laravel 5.8.

stefanzweifel commented 5 years ago

:warning: If you are using SQLite, the oldest supported version in Laravel 5.8 is SQLite 3.7.11. Laravel recommends running SQLite 3.8.8 or higher.

stefanzweifel commented 5 years ago

:warning: The Nexmo and Slack notification channels have been extracted into first-party packages. To use these channels in your application, run the following command to require the respective packages:

composer require laravel/nexmo-notification-channel
composer require laravel/slack-notification-channel
stefanzweifel commented 5 years ago

:warning: Laravel 5.8 correctly pluralizes multi-word model names ending in a word with an irregular pluralization. For example, Laravel 5.7 incorrectly pluralized the table name for the UserFeedback model as user_feedbacks. Laravel 5.8 correctly pluralizes this table name as user_feedback.

If you were relying on this irregular pluralization, you should rename your table name or set the $table property for your model. If you were overriding this behavior by setting the $table property, you may remove it and now rely on the framework.

stefanzweifel commented 5 years ago

:information_source: Shift noticed you have additional namespaces in your project. You should consider using the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel App namespace.

stefanzweifel commented 5 years ago

:tada: Congratulations, you're now running the latest version of Laravel. You can now use some of the micro Shifts to ensure your app is fully upgraded and following the Laravel recommended and community practices.