search

steffen-foerster / sailfish-barcode

22 stars 36 forks source link

Fix image capture #40

Closed monich closed 6 years ago

monich commented 6 years ago

There's no need for D-Bus, QQuickWindow::grabWindow() does the job. Also, moved camera to QML. There's no need to maintain native QCamera.

Please give it a try and update the version in Jolla store if you are OK with the solution.

steffen-foerster commented 6 years ago

Hi Slava

Thank you for your improvements. I'm no longer maintain the project. Do you want to become the app owner in the Jolla Store? I can ask the Jolla support to move the Codereader app to your account.

Cheers, Steffen

monich commented 6 years ago

Go ahead. It's a useful app, I would like to keep it working. My username in Jolla Store is slava.

steffen-foerster commented 6 years ago

Hi Slava

Jolla's developer support doesn't respond. Fell free to register the code as a new application in the Jolla store. Change the name harbour-barcode and it should work.

Cheers, Steffen

monich commented 6 years ago

Oh wait, I'm from Jolla myself! Let me ping somebody...

monich commented 6 years ago

Done! It's mine :) Should I make releases off my own fork then?

steffen-foerster commented 6 years ago

Good news! Yes, you can use your fork to make new releases. Thanks for maintain the application in the future!

On 10 Apr 2018, at 14:42, Slava Monich notifications@github.com wrote:

Done! It's mine :) Should I make releases off my own fork then?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

monich commented 6 years ago

OK, I'll merge this fix to my own fork then! Closing this one.

Olf0 commented 6 years ago

@monich: Hi Slava, can you please enable the "Issues" section in your fork of CodeReader at GitHub then, as it does not seem to make much sense to submit new issues here in @steffen-foerster's repository (especially for versions later than 0.7.13).

monich commented 6 years ago

Done!