steffenfritz / FileTrove

FileTrove indexes files and creates metadata from them.
https://filetrove.fritz.wtf
GNU Affero General Public License v3.0
32 stars 5 forks source link

[BUG] FTrove doesn't report status if NSRL cannot be downloaded #40

Closed ross-spencer closed 6 months ago

ross-spencer commented 6 months ago

Describe the bug A clear and concise description of what the bug is.

Currently getting a 403 from https://download.fritz.wtf/nsrl.db and the app isn't relaying that information.

image

Further, if I try to run install again, I get the error that existing folders exist. It should probably be possible to ignore these errors and continue.

To Reproduce Steps to reproduce the behavior:

Attempt to run the install processes while https://download.fritz.wtf/nsrl.db is unavailable.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

N/A

Additional context Add any other context about the problem here, e.g. test data

N/A

steffenfritz commented 6 months ago

Hi, thanks for the report!

I fixed the download problem, it was stuck on the generation of the new dataset; fixed that also in the production step.

The status 40x and installation should definitely be handled more stable, I will see how this can be solved.

ross-spencer commented 6 months ago

awesome, thanks @steffenfritz!

steffenfritz commented 6 months ago

Added download status error for everything that is not "200", so also a redirect, e.g. 302, triggers an alert.

The error message prints the status code and also a short message what to do. I don't want to implement the possibility to continue as there are many entry points for every installation step.

If an error occures during installation it will probably fail again, expect for the two downloads we handled here.

I will add more information to the documentation.