steffengy / schannel-rs

Schannel API-bindings for rust (provides an interface for native SSL/TLS using windows APIs)
MIT License
49 stars 51 forks source link

Bump windows-sys to 0.48.0 #93

Closed KapJI closed 1 year ago

KapJI commented 1 year ago

Updated version of https://github.com/steffengy/schannel-rs/pull/89.

Release notes: https://github.com/microsoft/windows-rs/releases/tag/0.48.0

KapJI commented 1 year ago

Looks like Appveyor has issues with TLS now and it's unable to download rust installer or crates.

I'd be glad if you help me with this or just check it locally to make sure all tests pass.

KapJI commented 1 year ago

By the way, maybe you want to migrate to Github Actions?

It's usually more reliable and has Windows Server 2022 and 2019 images. I can submit a PR for that if you want to.

steffengy commented 1 year ago

@KapJI yeah fine with migrating there vs spending time to fix it until the next appveyor thing breaks the next thing.

steffengy commented 1 year ago

@KapJI should be done.

KapJI commented 1 year ago

I rebased this PR but GH checks need approval. That's quite annoying and I usually change this setting to only require approval from new github users in my repos. This can be done in repo settings:

Screenshot 2023-07-03 at 12 13 41

Also looks like Appveyor needs to be disabled in Settings->Webhooks. Because now it fallbacks to default config.

steffengy commented 1 year ago

@KapJI Changed setting, appveyor is fully removed already but that preexisting last build check sticks around.

steffengy commented 1 year ago

Released as v0.1.22

djc commented 1 year ago

Thanks @KapJI and @steffengy for getting this done!