search

steffengy / tiberius

TDS 7.4 (mssql / Microsoft SQL Server) async driver for rust. Fork at: https://github.com/prisma/tiberius
Apache License 2.0
150 stars 2 forks source link

update the futures-state-stream dependency #75

Closed bbigras closed 4 years ago

bbigras commented 6 years ago

Just to make cargo outdated stop complaining. :)

steffengy commented 6 years ago

Yeah, planned but unfortunately that's a breakign change and is not quite trivial the last time I tried (implications on design).

steffengy commented 6 years ago

usage-wise it might also be better to switch away from it entirely. (as happening with tokio-postgres)

jonhoo commented 5 years ago

Another advantage to bumping the dependency is that we'll get https://github.com/sfackler/futures-state-stream/pull/3, which allows you to get back the SqlConnection on error. As observed in #94, there aren't that many cases where you'd be able to keep using the same SqlConnection after an error, but having the option would be nice.

allquixotic commented 5 years ago

Oof, I spent an hour or two flailing on this until I saw https://github.com/steffengy/tiberius/issues/72 -- sneaky! :( Looking forward to a fix here (or updated example that works with latest version of dependencies).

jonhoo commented 5 years ago

@steffengy any updates on this?

steffengy commented 5 years ago

@jonhoo No, I'm not planning to do this, since there are not really any worth upsides to it. The eventual restructuring when async/await is around will get rid of the futures-state-stream dependency entirely anyways. So no immediate plans in that area, I wouldn't expect it before 2020.

brokenthorn commented 5 years ago

Steffen, will async/await permit using the connection directly within a generic connection pool? (Can you move the connection?)

I think last time I tried, it was impossible with something like r2d2.

mar., 18 iun. 2019, 18:51 Steffen Butzer notifications@github.com a scris:

@jonhoo https://github.com/jonhoo No, I'm not planning to do this, since there are not really any worth upsides to it. The eventual restructuring when async/await is around will get rid of the futures-state-stream dependency entirely anyways. So no immediate plans in that area, I wouldn't expect it before 2020.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/steffengy/tiberius/issues/75?email_source=notifications&email_token=AAQFKXG33TN4TYA7PXTXZLTP3EABHA5CNFSM4FT3VCTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7C5UA#issuecomment-503197392, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQFKXBWEQXHWQBDXZENU23P3EABHANCNFSM4FT3VCTA .

steffengy commented 5 years ago

Shouldn't make any difference for connection pooling, I think you'll always need a pool that supports async, like https://github.com/onesignal/l3-37

steffengy commented 4 years ago

Closing this, as futures-state-stream won't be used by the async-implementation in 0.4 anymore.