steffest / BassoonTracker

Webbased old-school Amiga music tracker in plain old javascript - Plays and edits Amiga Mod files and FastTracker XM files
http://www.stef.be/bassoontracker/
MIT License
1.01k stars 61 forks source link

Protracker: notes above B-3 are not displayed but still played #24

Open blaqmajik opened 5 years ago

blaqmajik commented 5 years ago

The highest note you could play on ProTracker was B-3. But there are numerous MODs around that have been made in FastTracker which didn't have that limitation but made them unplayable on ProTracker - PT just displays ??? and chokes.

I guess you could argue it's better to replay them instead of just choking and Bassoon Tracker actually plays them like they were supposed to from a FT2 view but doesn't show any note value at all in the pattern view - it just shows the respective sample in the sample column.

In my opinion the right way to go for a modern tracker would be to play them but display a warning when saving a .MOD containing high notes.

steffest commented 5 years ago

Yep. There are also XM files that choke FastTracker - Made with Sk@le or something.

blaqmajik commented 5 years ago

Forgot to add an example:

https://modland.com/pub/modules/Protracker/Dalezy/dytec%20intro.mod

bryc commented 5 years ago

Technically those MODs will play fine in XM mode because it supports extended frequencies and is backwards compatible with PT effects. But BassoonTracker strips the data when loading.

So a simple solution is to just mute the bad frequencies rather than destroy them. The user can switch to XM mode to play the song properly and learn the differences between PC and Amiga mod trackers in the process :o)