search

steffest / BassoonTracker

Webbased old-school Amiga music tracker in plain old javascript - Plays and edits Amiga Mod files and FastTracker XM files
http://www.stef.be/bassoontracker/
MIT License
1.02k stars 61 forks source link

XM bugs #8

Closed bryc closed 5 years ago

bryc commented 5 years ago

This thing transforms whats supposed to sound like greensleeves into a new beast altogether... Also a synthetic device turns into a drum machine/Philip Glass piece.

steffest commented 5 years ago

Hey! Check with http://www.stef.be/bassoontracker/dev.html please, that's the current codebase, not with http://www.stef.be/bassoontracker/ which is an old deployed version :-) Newest version will be released soon.

bryc commented 5 years ago

Ah much better! Sorry didn't realize there was a dev page. "a synthetic device" doesn't play properly though. The hi-hat envelope doesn't work I think.

Also these files have issues:

steffest commented 5 years ago

That's an interesting one - "a synthetic device"! I didn't even know negative numbers in the volume effect tracks are supported, I have never seen that used before. I'll re-open the ticket and fix it later this week. Thanks for testing! I love this little quirky things.

bryc commented 5 years ago

Here's a bunch more bug reports that may need squishing. Trying to ignore the files that have "unimplemented" console logs you already know about (such as missing vibrato, panning etc). Tested using http://www.stef.be/bassoontracker/dev.html.

Some songs have a bug where a lowpass filter is enabled and remains even after loading new songs (gets "stuck"):

  1. vogue-ambient light.zip (Pattern 9)
  2. lesnik-hot dogs 3.xm (happens immediately in Pattern 1)
  3. lamb-happiness.xm (happens at very end of Pattern 1)

That requires refreshing the page to fix, so pretty bad.

A bunch of songs have issues with ADSR release, similar to springmellow p.II.xm above (seems to be the same issue in all).

  1. sinny-sky sunday.xm
  2. amove-lupo.xm
  3. ghidorah-dark december.xm
  4. xerxes-hesse's sovesang.xm
  5. jeroen tel-stranglehold.xm

Next, some have issues with arpeggios:

  1. maniac-disco zax.xm
  2. carter-dead feelings.xm
  3. med-halloween 2002.xm (seems that a 'note-off' technique isn't working here)
  4. lhs-brd keygen #2.mod and brd keygen #2.xm both don't work properly!

Some have an issue with fine tune:

  1. svenzzon-blizzard.zip (Error: unable to find finetune for note 0)
  2. strobe-balloons and shit.xm (Error: unable to find finetune for note undefined)

Some songs wont play at all due to unimplemented Global Volume Slide:

  1. reed-yet another discoism.xm
  2. cerror-for funky fish.xm
  3. radix-sunstreak.xm

And some others that have miscellaneous problems:

  1. dalezy-ghosts 'n goblins.xm (envelope sustain forever)
  2. dubmood-kolobki vodka dance.xm (wrong pattern jump in Pattern 2)
  3. kenet-chip or not.xm (delay/feedback effect not working as it should)
  4. dragoon-far rising sun.xm (pad samples not playing)
  5. mystic cloud-for old times sake.zip (Crashes on pattern 3)
  6. dubmood - cybernostra weekends.zip (Crashes on open - this is a weird custom file but opens fine in FT2/milky)
steffest commented 5 years ago

Thanks a MILLION! Really: I know how time-consuming it is to hunt down these examples.

I have split them up in separate issues (#9 to #14) - So I can close one from time to time :-) I'll dive in it during the Xmas holidays.

bryc commented 5 years ago

Thanks a MILLION! Really: I know how time-consuming it is to hunt down these examples.

It's no problem.. love fuzz-testing replayers personally (i modified bartman's AHX js replayer to fix numerous bugs by running all 1000+ songs in it looking for issues)

I'll dive in it during the Xmas holidays.

kinda fitting.. XM-mas ;)

Also a note in case you miss it: (issue was closed) I left a message in issue #10 about remaining E00 issues.

steffest commented 5 years ago

I think all issues have been fixed. Adding Autovibrato in the past weeks caused some regressions but I think we're good now.

bryc commented 5 years ago

awesome work <3 xm support is very solid now!

eteeselink commented 5 years ago

First of wow this is spectacularly awesome!! Extremely well done. I'm impressed across the board, but especially about the amazing mobile support. I couldn't have imagined that an oldschool style tracker UI could be user friendly (ish) on a tiny touch screen. Hats off!

That said, I don't think all the XM bugs have been fixed yet; I found an old (pretty bad) song of mine that's pretty different in Bassoon Tracker vs FT2 or XMPlay, especially in the first few patterns. Something with the pitch bend and also something with the timing I think.

https://www.stef.be/bassoontracker/?file=https%3A%2F%2Fapi.modarchive.org%2Fdownloads.php%3Fmoduleid%3D142113

https://modarchive.org/index.php?request=view_by_moduleid&query=142113

steffest commented 5 years ago

@eteeselink Yes indeed! The "M" command should also continue the previous "3" command slide value. that's a bug. I created a new ticket.

metaphysician commented 5 years ago

Hey there! noticed a nice thread here for XM-related playback bugs. i have a XM file that plays back pretty close to the original except that the panning doesn't work. i'm not a tracker expert but i opened this up in the FastTracker2 clone for macOS and it plays fine in that one. it seems the panning is added to the instrument/sample and not the Track?

anyway in Bassoon the file seems to be recognized as a mono only file and no panning seems to be working, although panning data does show on the sample editor (Bassoon and FT2 show it as happening on samples/instruments labeled '1','2' and '3', but the panning is heard in FT2 on Tracks 1-8 and 17-19). the volume automation does appear to be working on these instruments/samples though.

here's the link to the XM (i resaved this in the FastTracker II clone): https://www.dropbox.com/s/cjklawkg42go68w/dots1.xm?dl=0

and here's the MP3 of the song for comparison. the panning is pretty important, due to the ambient quality of the music: https://www.dropbox.com/s/qumv11abxgjad5t/dots.mp3?dl=0

interestingly enough it plays decently in VLC as well, although the panning and volume automation is more sharp, almost as if it only recognizes on/off instead of curves. sound quality is not as good Bassoon or FT2 though.

anyway - hope this helps a bit!

steffest commented 5 years ago

@metaphysician I bet you're using Safari? Somewhere deep down in the "Readme/Missing features and bugs" is this: "Safari doesn't support WebAudio StereoPanners so songs will be played in mono on Safari."

There's a shim that fixes this but it is too slow. Safari does support 3D panners though, so I could/should just implement that, haven't gotten around to it.

If you use Chrome or Firefox you will get stereo/panning.

metaphysician commented 5 years ago

@metaphysician I bet you're using Safari? Somewhere deep down in the "Readme/Missing features and bugs" is this: "Safari doesn't support WebAudio StereoPanners so songs will be played in mono on Safari."

There's a shim that fixes this but it is too slow. Safari does support 3D panners though, so I could/should just implement that, haven't gotten around to it.

If you use Chrome or Firefox you will get stereo/panning.

thanks! i was wondering if it wasn't possibly a browser issue. should have checked that before and avoided bothering you. apologies - it works great in Firefox!